Repository navigation
chore(deps): bump scikit-learn to 1.9 and surface version skew - #119
Merged
Merged
Conversation
Requires scikit-learn >=1.9.0,<1.10.0 (locks 1.9.1; adds narwhals). - Quality gate logs a WARNING with requested folds, speaker and sample counts when grouped CV falls back to a single grouped holdout. The fallback and the reported fold_strategy are unchanged. - Artifact metadata records the scikit-learn version at save time. - The pickle loader no longer drops InconsistentVersionWarning silently: it logs one WARNING per artifact with re-train or re-save guidance. Other unpickling warnings stay suppressed, as before. - CHANGELOG notes the one-time CV metric shift from the 1.8 StratifiedGroupKFold shuffle fix.
Owner
Author
|
Lane results on this branch:
|
jsugg
added a commit
that referenced
this pull request
Nov 10, 2026
chore(deps): bump scikit-learn to 1.9 and surface version skew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades scikit-learn to
>=1.9.0,<1.10.0(locks 1.9.1, released 2026-09-10; addsnarwhals2.28.0). Supersedes #76. Approved by the owner on condition that the owner's Intel macOS machine keeps working unchanged.Changes
pyproject.tomlspec plusuv.lock.ser/_internal/runtime/profile_quality_gate.py): when grouped CV is infeasible, a WARNING now logs the requestedn_splits, distinct speakers, samples, holdout size andfolds=1before the existing single grouped holdout. Fallback semantics and the reportedfold_strategyare unchanged.sklearn_versionat save time (optional field, validated; older artifacts without it still load).ser/_internal/models/artifact_loading.py): the blanketfilterwarnings("ignore")aroundpickle.load(generic noise suppression since a 2024 housekeeping commit; no test relied on it) is replaced by recording warnings.InconsistentVersionWarningis logged once per artifact and version pair at WARNING, naming the estimators and giving re-train or re-save guidance. Other unpickling warnings stay contained.StratifiedGroupKFold(shuffle=True)fix shifts grouped-CV metrics once.No quality-gate baselines are stored in the repo; gate thresholds are relative medium-versus-fast deltas, so nothing needed re-baselining.
Owner-machine compatibility (Intel i9, macOS 15.7, Python 3.12.8, numpy 1.26.4, torch 2.2.2)
Run with this branch's environment (scikit-learn 1.9.1) against a byte-identical copy of the owner's model:
predict_probaon 2000 fixed inputs versus the 1.7.2 reference: max abs difference 0.0, argmax agreement 1.0.ser --file sample.wav --profile fastoutput is byte-identical to the 1.7.2 run. The new loader WARNING appears exactly once, and no rawInconsistentVersionWarningleaks.Validation
Local gates:
make lock-check fmt lint type prepush-check type-completeness ci-contracts test-cov(1273 passed, 80.00%). New tests cover a real version-skewed pickle (warning logged once), quiet loads for matching versions and unrelated warnings,sklearn_versionstamping and validation, and the fallback WARNING. Lanes dispatched on this branch: results are posted below.